This comment was historically inside a block guarded by
`if let Some(otherwise_block) = otherwise`.

When rust-lang#120978 made the otherwise block non-optional, it also flattened that
region of code. Doing so left this comment awkwardly stranded above an
unrelated line of code, without its original context.

We can restore that context by moving it above the declaration of `otherwise`.

In llvm/llvm-project@9067070 they ended
up largely reverting
llvm/llvm-project@e817966. This means
the change we did in
rust-lang/rust@b378059 is now only
corrct for LLVM 18...so we have to adjust again.

@rustbot label: +llvm-main

…n, r=notriddle

Fix copy path button

Currently, on all nightly docs, clicking on the "copy path" button triggers a JS error. It's because changes in rust-lang#123706 forgot to update the JS (it contained an image before but not anymore).

I had to make some small changes in the CSS to fix the display when the button was clicked as well.

r? ``@notriddle``

…leanups, r=Nadrieril

Match ergonomics 2024: miscellaneous code cleanups

- Store `ByRef` instead of `BindingAnnotation` in `PatInfo`
- Rename `BindingAnnotation` to `BindingMode`

r? ``@Nadrieril``

cc rust-lang#123076

``@rustbot`` label A-patterns

Move confusing comment about otherwise blocks in `lower_match_tree`

This comment was historically inside a block guarded by `if let Some(otherwise_block) = otherwise`.

When rust-lang#120978 made the “otherwise block” non-optional, it also flattened that region of code. Doing so left this comment awkwardly stranded above an unrelated line of code, without its original context.

We can restore that context by moving it above the declaration of `otherwise`.

r? ``@Nadrieril``

…uviper

llvm: update riscv target feature to match LLVM 19

In llvm/llvm-project@9067070 they ended up largely reverting
llvm/llvm-project@e817966. This means the change we did in
rust-lang/rust@b378059 is now only corrct for LLVM 18...so we have to adjust again.

``@rustbot`` label: +llvm-main

fix: make `str::from_raw_parts_mut` `mut`

`str::from_raw_parts_mut` wasn't actually `mut`
rust-lang#119206